-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH] When the log offset is behind sysdb, this can repair it safely. #4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Add Log Offset Repair Tool and Make CheckCollections Return Log Offset This PR introduces a new Rust command-line tool for safely repairing log offsets by synchronizing them with sysdb, preventing log offsets from being moved backwards and thereby preserving invariants. It also updates the system to return the log offset in sysdb's CheckCollections gRPC/proto API, adds supporting plumbing to Go and Rust code (including new test coverage), and provides a test ensuring offsets never regress. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
d382541
to
dddd899
Compare
std::process::exit(13); | ||
} | ||
if collection_info.deleted[0] { | ||
eprintln!("cowardly refusing to do anything with a deleted database"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "deleted collection"?
dddd899
to
2da1187
Compare
Description of changes
This adds a tool to make the log offset match sysdb. Then a test to make sure it cannot move things
backwards breaking invariants.
Test plan
Added a test.
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
N/A