Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: Support for CLI in systemd examples #2217

Merged

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented May 16, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Added support for running Chroma with systemd and chroma cli
    • Added example files that can be directly copied
    • Fixed Type to match how service is run (simple for cli and forking for docker compose)

Test plan

How are these changes tested?

Tested with EC2 instance

Documentation Changes

N/A

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 6:28am

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

tazarov commented May 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

@tazarov tazarov changed the title [ENH]: Support for CLI in systemd examples [CHORE]: Support for CLI in systemd examples May 17, 2024
@tazarov tazarov requested a review from beggers May 17, 2024 12:13
@beggers
Copy link
Member

beggers commented May 24, 2024

Good to go once the linter passes!

@tazarov tazarov merged commit d11f93b into main May 27, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants