Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add call to component.changed from componentValueListener #654

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add call to component.changed from componentValueListener #654

wants to merge 1 commit into from

Conversation

davidhealey
Copy link
Contributor

Closes #653

@christoph-hart
Copy link
Collaborator

What's the rationale here? I'm hesitant to blindly accept this as it might cause subtly issues with callback execution loops.

@davidhealey
Copy link
Contributor Author

davidhealey commented Jan 26, 2025 •
edited
Loading

What's the rationale here? I'm hesitant to blindly accept this as it might cause subtly issues with callback execution loops.

In the documentation for addComponentValueListener it says:

This call sets the value (and causes changed() to be called) whenever a broadcaster message is sent.

But the changed callback is never called, hence this PR.

Related forum thread: https://forum.hise.audio/topic/11522/bug-componentvaluelistener-changed-not-firing?_=1737933201443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] componentValueListener changed not firing
2 participants
@davidhealey @christoph-hart