-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nvim terminal emulator key mappings #172
base: master
Are you sure you want to change the base?
Conversation
This looks fine to me, but I'm not an Nvim user. @blueyed @geoffharcourt are either of you Nvim users / willing to test this out and verify that all is well? |
It was added and reverted already: #129. |
Selfishly I'd rather have FZF work than terminal mode in nvim work. |
Of course. |
If there is a fundamental incompatibility here between fzf.vim and nvim terminal mode mappings, we'll need to stick with not including these mappings. That said, we can always add a section to the readme with notes on this. It's getting big enough that it might be time to pull all non-install non-usage content out into a separate document. |
I think it might be hard to detect FZF, since people may use FZF without the author's Vim plugin. |
It should be detectable as the program running in the term window.. and "fzf" shows up both when using |
|
so I press esc to get from terminal mode to normal mode, then use ctrl-j,k,l to move around, is that what you do as the workaround? |
@ssh352 I might come late to the party, but these mapping work for me in neovim 0.4.2:
|
It would be useful to have this feature. For fzf and other tools in a neovim terminal buffer, the convention seems to be to set filetype accordingly. Is it not possible to add the |
It turns out If not for the above caveat, the following would work.
Anyone see any problem with doing it this way? |
I bumped into this issue because I could not use my regular mappings to navigate from a In my .vimrc I had custom key bindings as described in https://github.com/christoomey/vim-tmux-navigator/#custom-key-bindings , and it took me a while to realize that my problem was caused because these instructions use 'nnoremap' and as such only work in normal mode. If I duplicate them as 'tnoremap' and add '' before each binding replacement, then I can navigate from a :terminal to another vim pane as I want. So in total I now have:
This may be obvious to some, but since it took me a while I guess there are other people that may find this helpful :-) |
No description provided.