Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for absolute file path in IPyPostProcessor #115

Closed
wants to merge 9 commits into from

Conversation

phelps-sg
Copy link
Contributor

This provides a fix for #114

@chrisjsewell
Copy link
Owner

Hey sorry for the late reply. This PR is a little more contencious, since there was probably a reason why I had that check in place, which I should have documented!
I think it might be better though, if relative paths were converted to absolute paths (os.path.abspath) at the frontend, to avoid any ambiguity in the the rest of the conversion process, i.e. about here:

@chrisjsewell
Copy link
Owner

also if you could split the custom style sheet into a separate PR thanks

@phelps-sg
Copy link
Contributor Author

Bear with me....Will split the pull request as soon as I figure out how to do that ;-).

@phelps-sg phelps-sg closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants