Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: recreate project using TypeScript #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IvanGodinez21
Copy link

Description

Describe the changes made by this pull request.

This PR recreates the entire source code into a TypeScript project.

add:

  • Additional configuration files.

modify:

  • All JS files were converted into TS files with ESM.

Related issues

List related issues (if any) and/or @mentions of the person or team responsible for reviewing proposed changes (left blank if not applicable).
List by using - [ ] and the issue number, e.g. - [ ] #1 or - [x] #1 if the issue is closed/solved.

  • None

Testing

Help me how can I test or look at the changes (left blank if not applicable).

  • Test files were also converted to TypeScript.
  • A configuration file was added for testing with Jest.

Notes

Some additional notes if necessary (left blank if not applicable).

  • Requires a better type definition for the functions parameters.
  • Some types were added.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@IvanGodinez21 IvanGodinez21 marked this pull request as ready for review May 8, 2024 03:52
@IvanGodinez21 IvanGodinez21 mentioned this pull request May 12, 2024
1 task
@chrishubert
Copy link
Owner

Hi @IvanGodinez21 thanks for your work, it's quite an intense rework!
It will take me some time to review, I'm quite busy lately..

Some follow-up questions:

  1. Have you managed to implement GitHub Action for the testing part?
  2. Is the swagger generator still working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants