-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fluent-ui-react-native controls and update various visual styles #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm occasionally seeing an app crash here when interacting with the checkbox. Repro:
Exception thrown at 0x00007FFC7E21B351 (RNSVG.dll) in artificialChat.exe: 0xC0000005: Access violation reading location 0x0000000000000000.
void SvgView::InvalidateCanvas() {
if (m_hasRendered) {
m_canvas.Invalidate();
}
} From the calling function (
It's null, because previously |
- Allows use of their Button type - Required importing SVG (see microsoft/fluentui-react-native#2613) - Which in turn requires importing the Win2D nuget - Also required switching to classic runtime (see microsoft/fluentui-react-native#1891)
Fix image size strings coming in (causing need to double select)
- added bottom button area of different color
chrisglein
force-pushed
the
furn_experimental
branch
from
March 14, 2024 16:00
dd90621
to
3d1ad7c
Compare
Default to direct debugging
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Fixes #115
Fixes #84
Fixes #58
Fixes #93
Related to #114
But pushed further by defining a custom Theme for Windows.
Workarounds needed: