Automatically update one-container image with new pihole images #252
+148
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
I've tested and verified that the automation works in my fork repo. It's already pushing new images automatically to Docker Hub and GHRC |
|
I've update the PR to automatically create a GitHub release in the same style as the history release notes (preview) |
mpgirro
force-pushed
the
main
branch
3 times, most recently
from
36a230f to
e9a2169
Compare
… fetching for Renovate and Dependabot
mpgirro
force-pushed
the
main
branch
3 times, most recently
from
f779d58 to
3170564
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
I've actually been looking to hand this repo over to someone else for a while -- this implementation looks good. Are you interested in becoming the official repo for this project? |
|
Yes, I can take over this project. How do you want to do this? Transfer the repository to me? |
|
Where is the dockerfile ? |
|
@BoBBer446 The Dockerfile is located at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automation to update the pihole image in the Dockerfile when new versions become available. It does so by:
Adding Renovate bot to update the version tag of Pihole in Dockerfile. You need to activate the Renovate App for this repository (it's free). Renovate normally opens PRs for manual review and approval. I've configured it to not open PRs for updates to the Dockerfile, but automatically commit all Docker tag updates without the need for manual interaction.
Adding a GitHub Actions workflow that builds and pushed the new images. This is only triggered when the Dockerfile is updated. The image gets tagged with the same version tag as the new pihole tag, as well as latest. New images get pushed to Docker Hub under your account, as well as GitHub Container Registry (GHCR) – simply because it's simply integrated to this repo.
Setup steps required to enable the new features
It's not sufficient to merge this PR. You need to do a few simple steps initially to enable the automation.
Activate the Renovate App for this repository. Afterwards, in the app settings at the bottom under "Repository access", add this repository so Renovate can start processing this repo. You will get an onboarding PR automatically if you do this before merging this PR. It's not necessary to merge this, since this PR already has the required
renovate.jsonfile.Add a new variable for GitHub Actions called
DOCKERHUB_USERNAMEwith your Docker Hub username.Add a new secret for GitHub Actions called
DOCKERHUB_TOKENwith an personal access token for Docker Hub. Generate the token here. The tokens needs "Read & Write" permissions.