Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added autobuild and autorelease workflow for the newest build #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liblame
Copy link

@liblame liblame commented Jan 11, 2023

Took the pr 147 from @tritethunder as an idea and reworked it a little bit. Sorry if i could have done that in his pr i am pretty new to git and github.

The workflow now checks if there is a new pihole container release, builds it and creates a new release in this repo.

Only caveat is that actions/create-release is not maintained anymore and uses NodeJS 12 and set-output. So maybe creating it automatically is not the best path.

You still have to put your dockerhub username and token under settings->secrets->actions

@liblame liblame changed the title added autobuild and autorelease workflow added autobuild and autorelease workflow for the newest build Jan 11, 2023
if: ${{ steps.latest_release.outputs.release != steps.previous_release.outputs.release }}

- name: Create release
uses: actions/create-release@v1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use https://github.com/softprops/action-gh-release for creating GH releases in my own projects. Works pretty well.

Copy link

@aleksanderbl29 aleksanderbl29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great!
The action looks good.

@watchingdogs
Copy link

@aleksanderbl29 How come then that this is not yet merged?

@aleksanderbl29
Copy link

aleksanderbl29 commented Jun 27, 2023

@watchingdogs
I can't seem to find a good reason other than the fact that chriscrowe hasn't been active for some time in this repo.
Personally, I've forked the repo and implemented this workflow so I can have the newest updates.

On the other hand you could question if it is really needed to have the absolute newest updates at all times - I like it, but def isn't needed.

aleksanderbl29 added a commit to aleksanderbl29/docker-pihole-unbound that referenced this pull request Jun 27, 2023
aleksanderbl29 added a commit to aleksanderbl29/docker-pihole-unbound that referenced this pull request Jun 27, 2023
Add auto-build-container.yml according to upstream chriscrowe#191 and change cr…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants