-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevents workers to stale when redis server went away #243
base: master
Are you sure you want to change the base?
Conversation
Throwing a CredisException instead of duplicating the error handling code would probably be a good idea. That said, it's interesting that Credis itself doesn't handle this... The reason we don't is it's supposed to do it for us. |
I've updated the pull according to your comment |
Looks good to me. I still find it odd that Credis doesn't handle that on its own, though. I wonder if it's handled correctly in a more recent version of the library... |
any chance that this pull requests gets merged? |
I had to update the commit due to missing constructor message on CredisException |
👍 |
I think in theory this should also be covered by #229, which was just merged down - essentially, the next operation against Redis on an instance that's gone away will cause the worker to throw an exception ( |
fix for #180
unfortunatelly I have no clue, why the first access on redis()->ping() does not throw the exception
anyhow this will prevent worker from getting useless after a network failure or redis restart