Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Events #90

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Add test for Events #90

merged 1 commit into from
Nov 1, 2017

Conversation

him2him2
Copy link
Collaborator

Reference: #89

Created tests for the events listed in https://github.com/choojs/nanomorph/blob/master/lib/events.js#L32

The following events fail:

  • onfocusin
  • onfocusout
  • ontouchcancel
  • ontouchend
  • ontouchmove
  • ontouchstart
  • onunload

@yoshuawuyts
Copy link
Member

This is amazing; great work! — perhaps it might be an idea to merge the passing tests first, and then add a separate PR for the failing tests? That way we can direct the focus on fixing the failing tests, while immediately getting the extra security of the other tests.

Does that make sense?

@him2him2
Copy link
Collaborator Author

him2him2 commented Nov 1, 2017

Hi @yoshuawuyts,

Totally makes sense. I will comment the failing tests out. That way as you work through the debugging you can turn them on to test as needed.

I moved the event tests into their own file to make them more manageable.

I believe the error is from bel. I have created event tests for that project too. Failing tests have been commented there as well. I will also create a new pull request there.

@yoshuawuyts
Copy link
Member

Awesome!

@yoshuawuyts yoshuawuyts merged commit 0abde32 into choojs:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants