Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise exception for new elements #33

Merged
merged 5 commits into from
Apr 17, 2024
Merged

raise exception for new elements #33

merged 5 commits into from
Apr 17, 2024

Conversation

yuanqing-wang
Copy link
Member

No description provided.

@ijpulidos
Copy link
Contributor

I don't think we are supporting DGL 2.x.x, as far as I can tell. We probably need to pin the DGL version to 1.1.2 similarly to what we are doing with espaloma.

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ijpulidos ijpulidos merged commit 3ce06dd into main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants