Philippines Pull Request #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layout the base province.
First 4 provinces encoded.
Encoded new Place Until Basilan
Until Bukidnon
Until Camiguin
Until Davao del Norte
until Guimaras
Until Lanao del Sur
Until Pampanga
Until Siquijor
until Southern Leyte
Done! For Review
Added someme contact details and change Compostela Valley to Davao de Oro
|
Thanks for your contribution! My apology for the very late reply. I have been too busy last months, but I'm planning to start delivering new releases in the next few months, merging new countries like the Philippines, added by you. However, you have closed your PR three days ago, can I reopen it? If so, could you please confirm that it is ready to review? |
|
Hello 🤗 This Pull Request was like 2 years ago 🤣 but yeah sure! I can reopen it for you. All of the data arrays are good. Just review it and let me know what I can do more. |
|
You're right! It's been a long time. My apology for that. I hope to be able to release a new version very soon. I'll let you know as soon as it's done! |
|
Sure no Problem! that would be great! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have completely filled up all the data pertaining to the provinces, cities & municipalities in the Philippines.
Waiting for your review and approval.
Best Regards,
Webb