Added new PBT example with transaction auth #21
Conversation
There was a problem hiding this comment.
Thanks for the contribution.
This seems like an opportunity to add a _beforeTokenTransfer hook, similar to , to PBTSimple, with all the new functionality in an extension (like https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/extensions/ERC721Pausable.sol).
| mapping(address => TokenData) _tokenDatas; | ||
|
|
||
| /** | ||
| * Mapping from userAddress to TransactionRequests |
| } | ||
|
|
||
| function actionTransferRequest(uint256 _tokenId, bool _decision) public { | ||
| if(msg.sender == owner) { |
There was a problem hiding this comment.
ownerOf(_tokenId)
Also in the current design it seems like someone else could call requestTransfer to block an approved transfer.
For example, if Bob requests to buy Alice's jacket, and Alice approves, a third party Joe could overwrite Alice's approval.
We may need to model this so that each requester has their own space, similar to _operatorApprovals https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a1948250ab8c441f6d327a65754cb20d2b1b4554/contracts/token/ERC721/ERC721.sol
There was a problem hiding this comment.
Appreciate that dude will get on the rework asap 👍🏻
There was a problem hiding this comment.
Awesome 👍
Also, it can get tricky because what if Alice is malicious and sells the item to Bob but revokes the approval after the physical is delivered, before Bob can scan?
A mechanism that forces Alice to keep the approval approved for a period of time could help here, but we can figure that out in a separate PR.
There was a problem hiding this comment.
Appreciate the PR @Arkay92. Internally we want to structure these approval mechanisms as PBT extensions. I will put together a solution for "delegated receivers" which you can base your implementation off of.
Many have been asking about transfer authorisation as an option to the PBT here is my proposed solution (open to any feedback on issues or improvements.
Gas Snapshot:
[PASS] testApprove() (gas:10677 -> 10677)
[PASS] testGetApproved() (gas:16241 -> 16241)
[PASS] testIsApprovedForAll() (gas:10051 -> 10051)
[PASS] testSetApprovalForAll() (gas:10714 -> 10714)
[PASS] testTransferFunctions() (gas:19077 -> 19077)
// PBT Simple Tests
[PASS] testGetTokenDataForChipSignature() (gas:127921 -> 127921)
[PASS] testGetTokenDataForChipSignatureBlockNumTooOld() (gas:122467 -> 122467)
[PASS] testGetTokenDataForChipSignatureInvalid() (gas:131763 -> 131763)
[PASS] testGetTokenDataForChipSignatureInvalidBlockNumber() (gas:122301 -> 122301)
[PASS] testIsChipSignatureForToken() (gas:216704 -> 216704)
[PASS] testMintTokenWithChip() (gas:176564 -> 176564)
[PASS] testSeedChipToTokenMapping() (gas:115247 -> 115247)
[PASS] testSeedChipToTokenMappingExistingToken() (gas:212100-> 212100)
[PASS] testSupportsInterface() (gas:7059 -> 7059)
[PASS] testTokenIdFor() (gas:117084 -> 116986)
[PASS] testTokenIdMappedFor() (gas:66778 -> 66680)
[PASS] testTransferTokenWithChip(bool) (runs: 256, μ: 211881, ~: 211785 -> runs: 256, μ: 211866, ~: 211785)
[PASS] testUpdateChips() (gas:171052 -> 171052)
[PASS] testUpdateChipsInvalidInput() (16433 -> gas: 16433)
[PASS] testUpdateChipsUnsetChip() (23430 -> gas: 23430)
// PBT With Auth Tests
[PASS] testActionTransferRequest() (gas: 57801)
[PASS] testGetTokenDataForChipSignature() (gas: 127771)
[PASS] testGetTokenDataForChipSignatureBlockNumTooOld() (gas: 122295)
[PASS] testGetTokenDataForChipSignatureInvalid() (gas: 131613)
[PASS] testGetTokenDataForChipSignatureInvalidBlockNumber() (gas: 122129)
[PASS] testIsChipSignatureForToken() (gas: 216515)
[PASS] testMintTokenWithChip() (gas: 176439)
[PASS] testRequestOwnership() (gas: 55251)
[PASS] testSeedChipToTokenMapping() (gas: 114990)
[PASS] testSeedChipToTokenMappingExistingToken() (gas: 212102)
[PASS] testSeedChipToTokenMappingInvalidInput() (gas: 17178)
[PASS] testSupportsInterface() (gas: 7105)
[PASS] testTokenIdFor() (gas: 116877)
[PASS] testTokenIdMappedFor() (gas: 66592)
[PASS] testTransferTokenWithChip(bool) (runs: 256, μ: 238545, ~: 238461)
[PASS] testUpdateChips() (gas: 170582)
[PASS] testUpdateChipsInvalidInput() (gas: 16433)
[PASS] testUpdateChipsUnsetChip() (gas: 23405)