Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for snap build #753

Closed
wants to merge 13 commits into from
Closed

Fix for snap build #753

wants to merge 13 commits into from

Conversation

raivisdejus
Copy link
Collaborator

@raivisdejus raivisdejus commented May 23, 2024

Created a custom version of CTranslate2 wheel that has libctranslate2.so with stripped execstack flags. Local validation of the snap passes and it works as with the default CTranslate2 wheel file. Build notes of the custom CTranslate wheel are here. https://github.com/raivisdejus/CTranslate2-no-execstack/

For snap build to fit GitHub actions environment limits I am switching to CPU torch in the snap. That is a version that will work for every user, for users with GPUs will attempt to install GPU specific torch in a later PR.

Also removed locales-all from snap as it is not needed and takes a lot of space in snap.

Also restoring previously disabled whisper types on Linux.

This PR also includes fix for macOS build from #751

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 81.46%. Comparing base (38f5d26) to head (72e309e).
Report is 9 commits behind head on main.

Current head 72e309e differs from pull request most recent head dd57e45

Please upload reports for the commit dd57e45 to get more accurate results.

Files Patch % Lines
buzz/file_transcriber_queue_worker.py 17.39% 19 Missing ⚠️
buzz/widgets/recording_transcriber_widget.py 22.22% 14 Missing ⚠️
buzz/widgets/transcription_task_folder_watcher.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   81.28%   81.46%   +0.18%     
==========================================
  Files          81       83       +2     
  Lines        3617     3928     +311     
==========================================
+ Hits         2940     3200     +260     
- Misses        677      728      +51     
Flag Coverage Δ
Windows 81.17% <44.61%> (-0.12%) ⬇️
macOS 81.16% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raivisdejus raivisdejus force-pushed the fix-snap-build branch 2 times, most recently from c02ffe8 to aa61bea Compare May 26, 2024 05:59
@raivisdejus
Copy link
Collaborator Author

Will merge cleaned up version of this PR via #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant