Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution locations #74

Closed
wants to merge 7 commits into from
Closed

Distribution locations #74

wants to merge 7 commits into from

Conversation

Nik4002
Copy link
Collaborator

@Nik4002 Nik4002 commented Apr 1, 2024

What does this PR do?

How was the functionality tested and verified?

All steps should be completed in the order presented, and you should not move on to the next step until the previous is completed.

  • The title of the html page is the same as the chart.
  • The meta_data.json file is filled in correctly (the description is a complete sentence, the title is the same as the visual).
  • The chart and its associated pages have been minified using the npm run process-visual command.
  • The visual is styled similar to other charts (centered title/subtitle, no legends unless absolutely necessary, etc.)
  • This visual was approved by the lead developer.
  • The visual was approved by the story's stakeholders.

);

// loads document properties and worksheets
await doc.loadInfo();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] reported by reviewdog 🐶
Parsing error: Unexpected token doc

@michplunkett michplunkett marked this pull request as draft April 1, 2024 05:50
@michplunkett
Copy link
Contributor

This hasn't been modified in a couple of months, I'm gonna kill the feature.

@michplunkett michplunkett deleted the distribution-locations branch August 30, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants