Rails 7.1 Upgrade #1186
Merged
Rails 7.1 Upgrade #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phinze
commented
Nov 10, 2023
| @@ -220,7 +220,7 @@ def audited_attributes | |||
| end | |||
|
|
|||
| # called when item is updated | |||
| def audited_changes | |||
| def audited_changes(**args) | |||
There was a problem hiding this comment.
This started taking args in collectiveidea/audited#657 so every Item interaction started throwing ArgumentErrors. Since we call super with no args I believe they should automatically be passed along, so it's fine to just capture the args to make the method signature match the callers.
jim
approved these changes
Nov 11, 2023
Fast on the heels of 7.0 here comes the latest and greatest Rails version!
|
@jim re-requesting review here since I made a lot more changes on this today ⚒️ |
jim
approved these changes
Nov 13, 2023
| system! 'bin/rails db:setup' | ||
|
|
||
| puts "\n== Loading dev data ==" | ||
| system! 'bin/rails devdata:load' |
There was a problem hiding this comment.
This line didn't make it over into the newer version. It theoretically saves first time devs a step when they start up the app for the first time, so probably worth keeping unless there's a reason we'd want bin/setup to leave the database totally empty.
|
|
||
| # Suppress logger output for asset requests. | ||
| # config.assets.quiet = true | ||
| config.assets.quiet = true |
Good catch @jim!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast on the heels of 7.0 here comes the latest and greatest Rails version!
What it does
Gets us on Rails 7.1.
Why it is important
Latest is greatest. And specifically this gets us access to background preprocessing of variants for finishing #1150
Implementation notes
auditedwe were using. The change we switched for was upstreamed and we need the more recent work to make it compatible with Rails 7.1. Just a couple of code changes were needed and tests seem to be passing okay.before_actiontypos.rake app:updateyielded diffs on many of the config files. I took all the changes tobinscripts whole hog and merged the rest. A second set of eyes across those diffs would be helpful though! 👀config/environments/test.rbwith a note explaining.bin/rails testwhich made the SCSS deprecation warnings get pretty annoying. Pulling in a workaround from scss Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. picturepan2/spectre#694lib/rails_solargraph.rb, so following a comment on the referenced gist I switch us to the solargraph-rails gem.