Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR adds support for selectively including inline fields found inside specific fenced code block types by introducing an Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client Code
participant QA as QuickAddApi
participant FVC as FieldValueCollector
participant FSP as FieldSuggestionParser
participant IFP as InlineFieldParser
Client->>QA: getFieldValues(fieldName, {includeInlineCodeBlocks: ["ad-note"]})
QA->>FSP: parse field filters (inline:true|inline-code-blocks:ad-note)
FSP-->>QA: FieldFilter {inline: true, inlineCodeBlocks: ["ad-note"]}
QA->>FVC: collectFieldValuesManually(fieldName, filters)
FVC->>IFP: getFieldValues(content, fieldName, {includeCodeBlocks: ["ad-note"]})
IFP->>IFP: parseInlineFields(content, {includeCodeBlocks: ["ad-note"]})
Note over IFP: filterFencedCodeBlocks() keeps only "ad-note" blocks
IFP-->>FVC: Set with field values from ad-note blocks
FVC-->>QA: aggregated field values
QA-->>Client: ["121212","343434"]
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
b967541
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://535df6d6.quickadd.pages.dev |
| Branch Preview URL: | https://998-bug-quickadd-api-getfiel-oo1g.quickadd.pages.dev |
Adds an opt-in path to include inline
field:: valuepairs from selected fenced code block types when collecting field suggestions.QuickAdd currently strips inline fields inside fenced blocks to avoid false positives, which means use cases like
ad-noteblocks cannot be queried viafieldSuggestions.getFieldValuesor{{FIELD:...|inline:true}}. This change keeps the existing default behavior and only includes fenced-block values when explicitly allowlisted.I considered changing
includeInline: trueto scan all fenced blocks, but rejected it because it would introduce broad regressions for users with real code blocks that contain::patterns.Reviewer focus and risk notes:
includeInlineCodeBlocks?: string[](only active whenincludeInlineis true)inline-code-blocks:<csv>inlineCodeBlocksso differing allowlists do not share stale resultsValidation performed:
bun run testbun run build-with-lintvault=devafter plugin reload:includeInline: true) =>["343434"]includeInlineCodeBlocks: ["ad-note"]) =>["121212", "343434"]Fixes #998
Summary by CodeRabbit
New Features
Documentation
Tests