Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds VALUE token "text" mapping support (syntax Changes
Sequence DiagramsequenceDiagram
participant User
participant UI
participant Formatter
participant Parser
participant Suggester
User->>UI: focus / request suggestions
UI->>Formatter: request suggestions (context)
Formatter->>Parser: parse VALUE token
Parser-->>Formatter: ParsedValueToken (suggestedValues, displayValues)
Formatter->>Suggester: supply displayValues as labels (suggestedValues as fallback)
Suggester-->>UI: show display labels to user
User->>UI: select display label (or type custom)
UI->>UI: map display -> actual value (via displayToValue) if selection from completion
UI-->>User: insert actual value into capture
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Support separate suggester display text and inserted values for VALUE option lists.
This adds
|text:support to{{VALUE:...}}so users can show friendly labels in the suggester while storing/inserting a different mapped value.What changed:
|text:and strict validation:This addresses the feature request to decouple display from inserted values in VALUE suggesters.
Fixes #588
Verification:
bun run testbun run lintbun run buildobsidian vault=dev plugin:reload id=quickaddobsidian vault=dev eval ...edge-case pack (7/7 pass)Summary by CodeRabbit
New Features
Bug Fixes / Validation
Documentation