Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ruby windows patches #1914

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

johnmccrae
Copy link
Contributor

Description

We had previously used a monkey patch in Chef Infra to update the ruby registry.rb file. We did that to overcome and encoding/decoding error. That monkey patch was not being applied to Ruby 3.1 and we started getting the expected registry encoding errors. I moved that monkey patch to use current standards and after that patch is applied, we also patch resolv.rb as insurance.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae johnmccrae requested review from a team as code owners June 13, 2024 21:46
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sean-simmons-progress sean-simmons-progress merged commit 28c9c9f into main Jun 14, 2024
6 checks passed
@sean-simmons-progress sean-simmons-progress deleted the jfm/chef18-registry-resolv-issues branch June 14, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants