Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove - from -enable_fips #1897

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Remove - from -enable_fips #1897

merged 1 commit into from
Apr 23, 2024

Conversation

tpowell-progress
Copy link
Contributor

Description

If you pass -enable_fips to configure, it thinks that a -e argument with nable_fips is being passed, which gets passed to ld, resulting in the following error:

                          D | 2024-03-21T12:23:06+00:00 | /usr/bin/ld: warning: cannot find entry symbol nable-fips; defaulting to 00000000000b3000

Per the man page for ld, -e specifies the entry point (as a symbol)

     -e symbol_name
             Specifies the entry point of a main executable.  By default the entry name is "start" which is found in crt1.o which contains the glue code need to set up and call main().

Since nable_fips isn't a symbol in the compiled output, it selects an arbitrary entry point, which causes a crash.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress tpowell-progress requested review from a team as code owners April 22, 2024 17:39
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@poorndm poorndm added the Expeditor: Skip All Used to skip all merge_actions. label Apr 23, 2024
@poorndm poorndm merged commit e4e5868 into main Apr 23, 2024
6 checks passed
@poorndm poorndm deleted the tp/openssl3debug branch April 23, 2024 14:42
@tpowell-progress tpowell-progress restored the tp/openssl3debug branch May 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Skip All Used to skip all merge_actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants