Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFCT-92] Reorder the guest customization task to complete after network update #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashiqueps
Copy link
Contributor

Signed-off-by: Ashique P S [email protected]

Description

Currently, the guest customization step is happening while cloning the VM and the network is getting added after that by a separate task. If the source template doesn't have any NIC and the user tries to add a network and do the guest customization, it will fail because of the order in which these tasks are being performed.

So in this PR, moving the guest_customization step after adding the NICs to the vm.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ashiqueps ashiqueps requested review from a team as code owners June 21, 2022 18:23
Signed-off-by: Ashique P S <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant