Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass sensitive #229

Closed
wants to merge 3 commits into from
Closed

Pass sensitive #229

wants to merge 3 commits into from

Conversation

gscho
Copy link
Contributor

@gscho gscho commented Jul 13, 2018

Description

  • Adds a guard to a ruby block inside the chef user resource
  • Passes the sensitive property to the ingredient config resource inside the automate resource

Issues Resolved

resolves #221
resolves #170

Check List

@gscho gscho requested a review from a team July 13, 2018 14:23
@gscho
Copy link
Contributor Author

gscho commented Jul 13, 2018

I pulled in the changes from PR #223 as well.

@wrightp
Copy link

wrightp commented Jul 16, 2018

The changes added from PR#223 were not identical. Specifically line 69 is correct the way it is and line 52 was missed. Looks like it was just a quick glance thing. I've already merged the other PR which was correct. If you resubmit this PR without the chef_org changes I'll get it merged. Please make sure the commit messages only reflect the new changes. Thanks!

@gscho
Copy link
Contributor Author

gscho commented Jul 16, 2018

@wrightp awesome. will do

@gscho gscho closed this Jul 16, 2018
@gscho gscho deleted the pass-sensitive branch July 17, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants