Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions on automate keys and license. #196

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

ncerny
Copy link
Contributor

@ncerny ncerny commented Aug 16, 2017

Signed-off-by: Nathan Cerny [email protected]

Description

[Describe what this change achieves]

Issues Resolved

Fixes #195

Check List

Copy link

@wrightp wrightp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -59,26 +59,41 @@
platform_version new_resource.platform_version if new_resource.platform_version
end

os_user = new_resource.config[/user\['username'\] ?= ?['"](?<username>.*)['"]/, 'username'] || 'delivery'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add a comment describing what these few lines are doing?

@wrightp wrightp requested a review from a team August 18, 2017 15:35
Copy link
Contributor Author

@ncerny ncerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been tested by customer and works as expected. +1 to merge from my perspective.

@wrightp wrightp force-pushed the nc/fix-delivery-license-perms branch from dc8bc62 to 9aed615 Compare August 23, 2017 15:59
@wrightp wrightp merged commit e4b0618 into master Aug 23, 2017
@tas50 tas50 deleted the nc/fix-delivery-license-perms branch November 30, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants