-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use default package provider on RHEL and SuSE instead of RPM; fixes #181 #182
Conversation
I can't remember why this was ever done. @schisamo @scotthain, I'd like to merge this, but I was wondering this you guys recall why we had to set the providers like this in the first place? |
@wrightp It was done because there was a bug in the yum provider, IIRC. I'd like to verify this on one of our sles machines before we merge. I'll test it out tomorrow and we can get it merged. |
Indeed I suspect it was this bug that may have been the original reason for using RPM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I figured out what the issue was before. In order to actually use the native Yum or Zypper packages, the chef repositories must be set up. If we use the Rpm package, it will download the appropriate package as needed. As a result, this does not currently work for suse/sles.
Without looking deeper at it - I'm not sure if the bug is in chef-ingredient or mixlib-install (or somewhere else) but trying to use this on sles/suse is not working.
@Poohblah if you want to include just the RHEL change we can get this through and open up another issue specifically around SLES/SUSE (it's a different problem, I think because SLES/SUSE/Zypper wasn't really taken into account in the original design/implementation) |
libraries/default_handler.rb
Outdated
@@ -60,8 +60,6 @@ def configure_from_source_package(action_name, local_path = nil) | |||
timeout new_resource.timeout if new_resource.timeout | |||
provider value_for_platform_family( | |||
'debian' => Chef::Provider::Package::Dpkg, | |||
'rhel' => Chef::Provider::Package::Rpm, | |||
'suse' => Chef::Provider::Package::Rpm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert the suse
change
Signed-off-by: hendrenj <[email protected]>
@scotthain removed SUSE changes and rebased on master. |
Thanks guys! |
Description
Use the default package provider for RHEL and SuSE instead of hardcoding RPM as the package provider.
Issues Resolved
#181
Check List