-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resources to support Chef 12.5 and 12.6 #146
Conversation
Signed-off-by: Jennifer Davis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chef-cookbooks/engineering-services
Thank you so much!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once Travis is happy.
The class_eval appears to only be needed for 12.5 and 12.6. I'm guessing this is the preferred workaround which I don't particularly like. We can get this merged to fix the issue for now, but I will probably fix this so we don't class_eval 12.7+. Please fix linting error and merge. Thank you for helping getting this along. |
Fauxhai!!! More to fix apparently. |
metadata.rb
Outdated
supports 'debian' | ||
supports 'rhel' | ||
supports 'suse' | ||
supports 'windows' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these platforms or platform families? If it's the former we need to add:
centos
freebsd
mac_os_x
solaris2
ubuntu
If it's the latter then we need to figure out how to represent these platforms as platform families. This cookbook essentially should support everything Chef supports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just trying to satisfy the error for the moment. Not the final solution.
Signed-off-by: Jennifer Davis <[email protected]>
ea73332
to
70fa970
Compare
I like the metadata "supports" rule, but let's deal with this later. There is still the task of migrating the omnitruck platform mapping to mixlib-install which will remove the OmnitruckHandler. That sounds like a good time to add the supported list of platforms. |
Description
Fix cookbook resources to support Chef 12.5 and 12.6
Issues Resolved
Issue #147
Check List