require_relative libraries modules #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Wright <[email protected]>
schisamo
suggested changes
Mar 26, 2017
| @@ -52,14 +52,17 @@ | |||
| platform_family = node['platform_family'] | |||
|
|
|||
| action_class do | |||
| require_relative '../libraries/helpers' | |||
There was a problem hiding this comment.
Style-wise we should always put requires at the top of the file.
There was a problem hiding this comment.
Not according to our custom resource docs. All modules in libraries are auto-loaded. Is there a style guide you are referring to?
|
I'm deleting this PR for now as not to cause any confusion why this PR was even created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Wright [email protected]
Description
This PR is a backup plan to getting the shd pipelines to work with the latest chef-ingredient. Technically, the code is to spec.
Note that the Helpers module loads fine which is loaded before the Handlers.
Issues Resolved
#140
Check List