Issue #14852: Fix performance test #14855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lmh-java
force-pushed
the
minghao/ci-patch
branch
2 times, most recently
from
deff6e0
to
a67f770
Compare
|
@romani, please take a look. https://github.com/checkstyle/checkstyle/actions/runs/8945787669/job/24575339430?pr=14855 The failing CI is because the associated issue is not approved. |
|
Please remove this commit created by me from web UI, it was mistake. |
Done |
nrmancuso
requested changes
May 7, 2024
Comment on lines
33
to
36
| - name: Checkout Pull Request Code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} |
There was a problem hiding this comment.
@Lmh-java why do we need anything more than this:
Suggested change
| - name: Checkout Pull Request Code | |
| uses: actions/checkout@v4 | |
| with: | |
| ref: ${{ github.event.pull_request.head.sha }} | |
| - name: checkout repo | |
| uses: actions/checkout@v4 |
?
There was a problem hiding this comment.
Oh, I see, didn't realize that the action checkout the pull request by default.
as shown in https://github.com/actions/checkout.
There was a problem hiding this comment.
@Lmh-java I think we can assume that most modern CI will run on the reference it was triggered from unless otherwise specified.
Lmh-java
force-pushed
the
minghao/ci-patch
branch
from
4fa3530
to
3fffe45
Compare
nrmancuso
approved these changes
May 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #14852.