Issue #13345 Enable UnnecessarySemicolonAfterOuterTypeDeclarationChec… #14850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathm3
force-pushed
the
EnableUnnecessarySemicolonAfterOuterTypeDeclarationTest
branch
from
bcec230
to
9f50210
Compare
|
@prathm3 , please fix CI failures. |
prathm3
force-pushed
the
EnableUnnecessarySemicolonAfterOuterTypeDeclarationTest
branch
2 times, most recently
from
19b0f59
to
7080b53
Compare
Please review, All checks have passed. |
mahfouz72
reviewed
May 4, 2024
Comment on lines
14
to
19
| class Example2 { | ||
|
|
||
| }; // violation |
There was a problem hiding this comment.
add nested class here to make the structure of both examples is exactly the same
rule no. 1 in #13345 (comment)
…arationCheckExamplesTest
prathm3
force-pushed
the
EnableUnnecessarySemicolonAfterOuterTypeDeclarationTest
branch
from
7080b53
to
a384769
Compare
|
Github, generate site |
romani
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13345
Changes done as a part of PR
src/xdocs/checks/coding/unnecessarysemicolonafteroutertypedeclaration.xml.templatesrc/xdocs/checks/coding/unnecessarysemicolonafteroutertypedeclaration.xmlwith new changessrc/xdocs-examples/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessarySemicolonAfterOuterTypeDeclarationCheckExamplesTest.java- Removed disabled annotation, updated tests with new Example.java file