Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v7.2.0 #186

Closed
wants to merge 1 commit into from
Closed

release: v7.2.0 #186

wants to merge 1 commit into from

Conversation

snprajwal
Copy link
Member

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.82%. Comparing base (a9064d7) to head (18a65de).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   50.82%   50.82%           
=======================================
  Files          21       21           
  Lines        1948     1948           
=======================================
  Hits          990      990           
  Misses        819      819           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snprajwal
Copy link
Member Author

Okay, looks like we'll need some fixes before making the release. I'm away until Sunday, I'll do it once I'm back.

@snprajwal
Copy link
Member Author

@rst0git it's interesting how I was able to create this branch through the web UI, but now it's protected - I can neither push to it, nor delete it. I meant to create the branch on my fork, but ended up creating it on this repo instead. Do we apply protection rules on non-default branches too?

@rst0git
Copy link
Member

rst0git commented Aug 28, 2024

Do we apply protection rules on non-default branches too?

I am not sure, we usually don't create branches in the main repository. It might be better to open another pull request and we can close this one.

@adrianreber do you have permissions to delete this branch?

@snprajwal snprajwal closed this Aug 28, 2024
@adrianreber adrianreber deleted the release branch August 29, 2024 13:40
@adrianreber
Copy link
Member

Branch protection is on all branches (*). I did not set up the branch protection, but it does not sound bad. I removed the release branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants