-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display file descriptors #74
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 80.00% 82.17% +2.17%
==========================================
Files 3 4 +1
Lines 435 533 +98
==========================================
+ Hits 348 438 +90
- Misses 64 70 +6
- Partials 23 25 +2
☔ View full report in Codecov by Sentry. |
c17e722
to
fb813c2
Compare
53df1e2
to
970187f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The binary size check does not seem to work any more. I just see one run of it. No comparison. Can you add an example of what this looks like in the PR description? |
The binary size workflow should be working now, I rebased this branch against main. |
de4c12b
to
e94cd18
Compare
I forgot to do a nil pointer check while searching for the process node in the tree. Updated the commit with those changes now. |
The file descriptors opened by the processes in the checkpoint can now be viewed with the `--fds` flag. Signed-off-by: Prajwal S N <[email protected]>
The file descriptors opened by the processes in the checkpoint can now be viewed with the
--fds
flag. This currently displays the file type, FD, and the path.An example output for a checkpoint of httpd container (provided by @rst0git):