-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to print metadata information #148
Open
adrianreber
wants to merge
3
commits into
checkpoint-restore:main
Choose a base branch
from
adrianreber:2024-10-17-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add option to print metadata information #148
adrianreber
wants to merge
3
commits into
checkpoint-restore:main
from
adrianreber:2024-10-17-metadata
+85
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 81.51% 77.76% -3.75%
==========================================
Files 11 11
Lines 1082 1417 +335
==========================================
+ Hits 882 1102 +220
- Misses 128 241 +113
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. |
rst0git
reviewed
Oct 17, 2024
@adrianreber Would it make sense to update the examples in the README file? The metadata seems very useful:
|
This adds an option to print out container metadata. In the case of CRI-O this can look like: ├── Metadata │ ├── Name: counters │ ├── Namespace: default │ └── Annotations │ ├── io.kubernetes.cri-o.ImageName: quay.io/adrianreber/counter:latest Currently this contains all annotations from the container. Signed-off-by: Adrian Reber <[email protected]>
The output of '--all' changes with the introduction of additional information. This removes two hardcoded lines and adds it to the section that the line just needs to exist somewhere. Signed-off-by: Adrian Reber <[email protected]>
Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2024-10-17-metadata
branch
from
October 23, 2024 06:55
fc5ebfa
to
692adc3
Compare
@rst0git updated, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to print out container metadata. In the case of CRI-O this can look like:
Currently this contains all annotations from the container.