Fix location of Open Files in tree #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 81.50% 81.51%
=======================================
Files 11 11
Lines 1060 1082 +22
=======================================
+ Hits 864 882 +18
- Misses 126 128 +2
- Partials 70 72 +2 ☔ View full report in Codecov by Sentry. |
adrianreber
force-pushed
the
2024-10-15-fix-tree
branch
from
6808fb0
to
9ae346b
Compare
Signed-off-by: Adrian Reber <[email protected]>
Without this patch the output used to look something like this │ └── [1] bash │ ├── Environment variables │ ├── [8] /usr/bin/coreutils │ │ ├── Environment variables │ │ └── Open files │ │ └── [root] / │ ├── [7] /usr/bin/python3 │ │ ├── Environment variables │ │ ├── Open files │ │ │ └── [root] / │ │ └── Open sockets │ │ └── [TCP (LISTEN)] 0.0.0.0:8088 -> 0.0.0.0:0 (↑ 16.0 KB ↓ 128.0 KB) │ └── Open files │ └── [root] / Which is wrong as the list of open files (and sockets) for the first process is after the child processes. With this change the order is now correct: │ └── [1] bash │ ├── Environment variables │ ├── Open files │ │ └── [root] / │ ├── [7] /usr/bin/python3 │ │ ├── Environment variables │ │ ├── Open files │ │ │ └── [root] / │ │ └── Open sockets │ │ └── [TCP (LISTEN)] 0.0.0.0:8088 -> 0.0.0.0:0 (↑ 16.0 KB ↓ 128.0 KB) │ └── [8] /usr/bin/coreutils │ ├── Environment variables │ └── Open files │ └── [root] / Each process has its own "Open files" and "Open sockets". It was always correct for "Environment variables". Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2024-10-15-fix-tree
branch
from
9ae346b
to
fb17c92
Compare
Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2024-10-15-fix-tree
branch
from
fb17c92
to
b2f5b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the output used to look something like this
Which is wrong as the list of open files (and sockets) for the first
process is after the child processes. With this change the order is now
correct:
Each process has its own "Open files" and "Open sockets". It was always
correct for "Environment variables".