chore: Align with upstream #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* try to force hide the view if it ever gets shown by accident * deregister the view container if context key isn't honored
* Revert "try to force hide the view if it ever gets shown by accident (#232277)" This reverts commit f0c6346. * just skip the registration if we have state to hide keep keybinding
(probably) Fixes #228211
Fixes #226474 It looks like this bug is at least 9 years old! It took me a minute to figure out what the intention was here. I think the goal was to keep showing the hover if the user is pressing ctrl/cmd without sticky hovers enabled (e.g. to allow copying) but it was in the wrong check and would confusingly dismiss the hover when the mouse moved if ctrl/cmd was pressed.
This was unintentionally enabled in some refactors last month. Fixes #228317
debug: fix hover variable value disappears on key down
…it (fix #231922) (#232229) * Dragging an active view between side bars or panel does not activate it (fix #231922) * address feedback
* Use async find provider only for file scheme (#230592) * only use asyncfindprovider for file scheme * add vscode remote * Use async find provider only for file scheme (#230592) * only use asyncfindprovider for file scheme * add vscode remote * 💄
* For the clear command, use `lastFocusedWidget` over `openView` re microsoft/vscode-copilot#9865 * inline chat should react to widget clearing
also fix microsoft/vscode#231946 by replace icons with the spinner so that width stays constant
Fixes #230584
* chore - clean up `LanguageModelChatProvider` (step 1) * fix compilo
Fixes #232408
Move fish SI script out of xdg named dir
Improve quoting in executeCommand API
introducing text area into the edit context to handle correctly the paste event
* add more logging * add more log
allow cursor move during composition
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Put terminal quick fixes into the SI menu too
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Started failing with #232968
Fix failing test on macOS
vscode-upstream-sha1: 231d373 rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
… from the open-vsx.org Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
RomanNikitenko
force-pushed
the
align-with-upstream
branch
from
2fea955
to
511e4ca
Compare
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-448-amd64 |
RomanNikitenko
requested review from
azatsarynnyy and
vitaliy-guliy
as code owners
vitaliy-guliy
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
electronandNode.jsversions as20.18.0node.js is not available in images that we use for buildingche-codeassembly, see RomanNikitenko@3cd01ef and RomanNikitenko@b63cdb1What issues does this PR fix?
eclipse-che/che#23217
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder