Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Actions: Enable workflow on fork PR #877

Merged
merged 2 commits into from Apr 30, 2024

Conversation

kyleecodes
Copy link
Member

@kyleecodes kyleecodes commented Apr 21, 2024

Issue link / number:

N/A

What changes did you make?

New workflow build-and-test-fork-prs created for fork prs to enable secrets access.
Uses pull_request_target but only if the workflow triggering actor is from Chayn.
This means pull_request_target will not grant secret access to anyone who makes a pull request.
Instead, all public forks triggered by Chayn team members will have access to secrets, even on public forks.

Why did you make the changes?

To save developer time by removing the need to run tests locally for contributor pull requests. With this, devs can conveniently run tests for public pull requests in the UI.

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 10:29pm

@kyleecodes kyleecodes changed the title Actions: Run tests from fork. Actions: Skeleton to run tests from fork Apr 21, 2024
@kyleecodes kyleecodes changed the title Actions: Skeleton to run tests from fork (DONT MERGE) Actions: Skeleton to run tests from fork Apr 21, 2024
@kyleecodes kyleecodes closed this Apr 21, 2024
@kyleecodes kyleecodes changed the title (DONT MERGE) Actions: Skeleton to run tests from fork Actions: Skeleton to run tests from fork Apr 22, 2024
@kyleecodes kyleecodes changed the title Actions: Skeleton to run tests from fork [WIP] Actions: Skeleton to run tests from fork Apr 24, 2024
@kyleecodes kyleecodes reopened this Apr 24, 2024
Enable workflow run on fork PRs by verifying workflow trigger actor permission.
New workflow for build-and-test for fork PRs created.
@kyleecodes kyleecodes changed the title [WIP] Actions: Skeleton to run tests from fork [WIP] Actions: Enable workflow on fork PR Apr 30, 2024
@kyleecodes kyleecodes merged commit adba911 into develop Apr 30, 2024
5 checks passed
@cypress cypress bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant