Introduce ALREADY_APPLIED error code for duplicate partner access code usage #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new error code, ALREADY_APPLIED (along with the related test cases) to provide a more accurate error message for users who attempt to apply a partner access code that has already been used with their account.
|
Thank you @mayank-sahai |
eleanorreem
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks so much for this contribution @mayank-sahai ⭐ All looks great to me 😄
|
@eleanorreem can you also please review my frontend MR and let me know if any change is required? thanks🙌 |
|
Absolutely ! Sorry i didn't see that PR either. We've set up better notifications now 🤦 I will do that today as well ⭐ Thats fab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#387
What changes did you make?
This commit introduces a new error code, ALREADY_APPLIED (along with the related test cases). This error will be returned when the access code has already been applied to the account.
Also handled the case when the access code is already used by another user. In this scenario, an ALREADY_IN_USE error will be returned.
Why did you make the changes?
To provide a more accurate error message for users who attempt to apply a partner access code that has already been used with their account or another user's account.