Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Scroll the notification in to view #9082

Closed
wants to merge 10 commits into from

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Mar 8, 2024

Pull Request Template

Description

This PR includes scrolling the notification card into view when we navigate through the inbox header.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Loom video
https://www.loom.com/share/40663df92a214f3ba213d9ce4c15c57f?sid=c5000a84-9dc9-478b-b3f4-88466bab8d04

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@iamsivin iamsivin self-assigned this Mar 8, 2024
@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-9082 March 8, 2024 04:22 Inactive
@iamsivin
Copy link
Member Author

Closing this PR will reopen when we are back on this feature.

@iamsivin iamsivin closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants