Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tables): update tests after changes on lipgloss #394

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

andreynering
Copy link
Member

This PR is basically to just update the tests to make them pass, as there are some small differences with the new table work.

Before merging:

@bashbunni
Copy link
Member

If I run these in ansi with go test ./... all tests pass, but when I use the -run directive, they fail 🤔 It seems that it's adding a selected row style to the first row by default when I run go test -run TestRendererIssues

image
vs
image

@bashbunni
Copy link
Member

Just added a commit that fixes the issue I reported above

@bashbunni
Copy link
Member

It looks like we're still adding extra lines between rows. There should also be ellipsis if we're cutting content (see Architectures column). I think we updated the test data though, so tests are passing

Test outputs

TestRendererIssues/44

Expected:
image
Got:
image

@andreynering
Copy link
Member Author

Thank you @bashbunni!

I disabled content wrapping, which ensures we're having the same behavior as before, but with the fix of showing the ellipsis now as opposed to just cutting the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants