distribute_setup.py: migrate away from distutils. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following [PEP 632], the distutils module is deprecated. In gff, this module is still in use for it's logging facility, so a contemporary approach would be to use the "logging" module instead of distutils. logging.warning behaves the same way as distutils.log.warn; there was also a logging.warn function but it is deprecated in favor of warning, thus this patch does not attempt to do something smart with things allowed by the import semantics. [PEP 632]: https://peps.python.org/pep-0632/ Signed-off-by: Étienne Mollier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PEP 632, the distutils module is deprecated. In gff, this module is still in use for it's logging facility, so a contemporary approach would be to use the "logging" module instead of distutils. logging.warning behaves the same way as distutils.log.warn; there was also a logging.warn function but it is deprecated in favor of warning, thus this patch does not attempt to do something smart with things allowed by the import semantics.