-
Notifications
You must be signed in to change notification settings - Fork 427
CLS/chplcheck: Support editor agnostic configuration files #26978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7eea477
to
4da2dd2
Compare
DanilaFe
approved these changes
Mar 28, 2025
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
bfe9f82
to
58ed92f
Compare
Signed-off-by: Jade Abraham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the existing support for using ConfigArgParse to allow for editor-agnostic configuration files. This allows users to specify options for their project in an editor-agnostic way, and then allow CLS/chplcheck to auto-pick them up.
This also integrates nicely with Mason, allowing users to specify CLS/chplcheck options in a Mason.toml file. For example
This PR also expands the options for chplcheck, allowing the following
This lets users specify all the options needed in 1 file, and then from the project root running just
chplcheck
does the right thingThis PR also adds the -M/--module-dir options to CLS, allowing users to add a few paths to the module search path instead of needing a full .cls-commands file. This also includes adding an internal, developer only, ability to set the root directory for standard modules.
[Reviewed by @DanilaFe]