Skip to content

Install CMake files for Chapel projects #26937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Mar 18, 2025

Adds an install step to move the CMake module files in util/cmake to CHPL_HOME/lib/INSTALL_PREFIX/lib/cmake/chpl

This makes these files readily available to users without needing to copy the files into their project

testing

  • build from source with CHPL_HOME build puts the files in the right place
  • install from source with chpl-home build puts the files in the right place
  • install from source with prefix build puts the files in the right place
  • homebrew changes work as expected
  • rpm changes work as expected
    • tested fedora 41
  • apt/deb changes work as expected
    • tested ubuntu 24

[Reviewed by @arezaii]

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 force-pushed the install-cmake-files branch from 445043a to 3f2bd2c Compare April 14, 2025 15:02
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 requested a review from arezaii April 14, 2025 21:24
Copy link
Collaborator

@arezaii arezaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jabraham17 jabraham17 merged commit f19f194 into chapel-lang:main Apr 15, 2025
10 checks passed
@jabraham17 jabraham17 deleted the install-cmake-files branch April 15, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants