Skip to content

Remove unnecessary code after qthreads upgrade #26842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Remove unnecessary code after qthreads upgrade #26842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions runtime/etc/rtmain.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
// This file is used in LLVM backend compiles to compile the header
// declarations for the Chapel runtime into an LLVM module.

// Reduce our exposure to overloads of symbols with the same name
// when parsing runtime headers in C++ mode during our LLVM codegen.
// https://github.com/chapel-lang/chapel/issues/25506
#define CHPL_AVOID_CPP_CODE 1

#include "stdchpl.h"

#include "chpl-gen-includes.h"
2 changes: 0 additions & 2 deletions util/chplenv/chpl_qthreads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ def get_uniq_cfg_path():
def get_compile_args():
ucp_val = get_uniq_cfg_path()
bundled, system = third_party_utils.get_bundled_compile_args('qthread', ucp=ucp_val)
# qthread headers may have unused variables
bundled.append('-Wno-error=unused-variable')
return (bundled, system)


Expand Down