Add tests for checking integral return types #26603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arezaii
force-pushed
the
dyno-int-uint-conditionals
branch
2 times, most recently
from
557e41e to
d118884
Compare
arezaii
force-pushed
the
dyno-int-uint-conditionals
branch
2 times, most recently
from
65f73f2 to
b87f731
Compare
benharsh
approved these changes
Apr 11, 2025
arezaii
force-pushed
the
dyno-int-uint-conditionals
branch
from
42d00e7 to
c20a02e
Compare
Signed-off-by: Ahmad Rezaii <[email protected]>
arezaii
force-pushed
the
dyno-int-uint-conditionals
branch
from
c20a02e to
86b9d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test cases for mixing of
intanduinttypes in conditional branches for both dyno and prod.A discrepancy in return types between prod and dyno was noticed in https://github.com/Cray/chapel-private/issues/6829 and determined to be a bug in prod, captured in #26991.
These tests capture the current state of prod and dyno, placing the prod tests in a future.
TESTING:
[Summary: #Successes = 17797 | #Failures = 0 | #Futures = 906][reviewed by @benharsh - thanks!]