Demonstration for HDF5 Tables #14873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daviditen, @ronawho -- for your reviewing pleasure. |
|
@daviditen - are you able to review this? |
|
Sorry for the delay on getting this reviewed. It looks great overall. There are a few things that will need to be updated to work with 1.22/master. A few places need to be updated to be 0-based instead of 1-based, and I'll plan to merge and do those updates on Monday. |
|
@daviditen -- thanks! Yes, I'm still getting used to the Great Index Shift of 2020. :-) |
|
I'd be in favor of moving this to test/library/packages/HDF5/{htable, or whatever} so it's easier to find and run all hdf5 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14551 by removing the noise from commits from rebasing.