Core library cleanup #1457
Merged
Core library cleanup #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguevremont
approved these changes
Mar 13, 2025
| @@ -97,17 +95,17 @@ maximum_number_of_previous_solutions() | |||
| */ | |||
| inline unsigned int | |||
| number_of_previous_solutions( | |||
| Parameters::SimulationControl::TimeSteppingMethod method) | |||
| const Parameters::SimulationControl::TimeSteppingMethod method) | |||
There was a problem hiding this comment.
Shouldn't the const be absent here, given the link in the description?
There was a problem hiding this comment.
Very good question friend. Because this is an inline function the function is defined afterwards. So here the header does not contain the function prototype but the function itself. Consequently, the const has to be there because the function is defined straight up afterwards :)
There was a problem hiding this comment.
Oh that makes sense! Thank you for the explanation
blaisb
force-pushed
the
core_library_cleanup
branch
from
9f00f03 to
2ac943a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the aims of deploying a CI that would check for warnings using the clang compiler, I am fixing some of these warnings ahead of time by cleaning the code file by file. This PR addresses this for only 4 files in the core library, but this has impact beyond the code library itself.
One important thing, I have learnt that according to clang we should not mark stuff const in the .h file, but on in the .cc file ( see https://stackoverflow.com/questions/38660537/why-is-const-unnecessary-in-function-declarations-in-header-files-for-parameters) and so I have applied these changes also here.
Testing
All unit tests should not change. They did not.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: