Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dem test and function full contact #1453

Merged
merged 14 commits into from
Mar 14, 2025
Merged

Dem test and function full contact #1453

merged 14 commits into from
Mar 14, 2025

Conversation

marineharel
Copy link
Collaborator

@marineharel marineharel commented Mar 11, 2025

Description

Function for dem contact tests which returns an output of time, force, torque, overlap, tangential overlap, velocities and angular velocities for the full duration of the contact between two particles.

Testing

Function used in dem test particle_particle_full_contact

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

Copy link
Collaborator

@oguevremont oguevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice PR! Some minor comments only

@blaisb blaisb requested a review from OGaboriault March 12, 2025 13:20
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very few comments. Very good work @marineharel

Copy link
Collaborator

@OGaboriault OGaboriault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just minor things/ questions :)

@blaisb blaisb merged commit 5c883a1 into master Mar 14, 2025
11 checks passed
@blaisb blaisb deleted the dem_test_full_contact branch March 14, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants