-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dem test and function full contact #1453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice PR! Some minor comments only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very few comments. Very good work @marineharel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, just minor things/ questions :)
Description
Function for dem contact tests which returns an output of time, force, torque, overlap, tangential overlap, velocities and angular velocities for the full duration of the contact between two particles.
Testing
Function used in dem test particle_particle_full_contact
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: