Documentation mobility model, cahn-hilliard filtering #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
requested changes
Feb 9, 2024
| @@ -20,57 +20,66 @@ | |||
| #include <core/interface_property_model.h> | |||
|
|
|||
| /** | |||
| * @brief Abstract class that allows to calculate the | |||
| * mobility for the Cahn-Hilliard-Navier-Stokes equations. | |||
| * @brief Implementation of a general case computation of the mobility | |||
There was a problem hiding this comment.
What do you mean by general case here? It's a bit hard to understand.
There was a problem hiding this comment.
There exist different models to compute the mobility, that is what I mean. I'll write it to clarify
There was a problem hiding this comment.
Actually I'll just remove the "general case", it is not required
PierreLaurentinCS
force-pushed
the
documentation_cahn_hilliard
branch
from
4e02d9e to
8927e1f
Compare
blaisb
approved these changes
Feb 9, 2024
PierreLaurentinCS
added
Ready for review
and removed
Reviewed and waiting for changes
labels
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Documentation for the mobility models and phase filtering for Cahn-Hilliard equations Former-commit-id: ad73849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem