Tracer drift flux model #1014
Merged
Tracer drift flux model #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem For some simple cases of tracer modeling, we need to account for tracer drift to have a simple model for dilute multiphase simulation. This is currently not possible. Description of the solution Add a simple drift flux velocity model for the tracer physics. This is just a user-defined function that adds a supplementary velocity on top of the fluid velocity to the tracer physics. How Has This Been Tested? This is a very minimal modification which just adds a velocity to the fluid velocity so this does not require specific unit test. If all the regular tests still pass, this implementation should be valid. Documentation Documentation of the class was added and class is adequately documented. Former-commit-id: 804f64f
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem For some simple cases of tracer modeling, we need to account for tracer drift to have a simple model for dilute multiphase simulation. This is currently not possible. Description of the solution Add a simple drift flux velocity model for the tracer physics. This is just a user-defined function that adds a supplementary velocity on top of the fluid velocity to the tracer physics. How Has This Been Tested? This is a very minimal modification which just adds a velocity to the fluid velocity so this does not require specific unit test. If all the regular tests still pass, this implementation should be valid. Documentation Documentation of the class was added and class is adequately documented. Former-commit-id: 804f64f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation