Fix read checkpoint for the matrix-free application #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix_mf_restart
blaisb
approved these changes
Jan 29, 2024
|
Sorry about that, I should have caught that error before merging the other PR. |
blaisb
pushed a commit
that referenced
this pull request
Jan 30, 2024
Description of the problem Eight tests were failing in debug mode due to the different behavior of the interpolate function of the solution transfer for different types of vectors. Description of the solution Revert change made in #1007 for the init_temporary_vector() function.
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem The restart option was not working in parallel for the matrix-free application. Description of the solution Use locally relevant vectors for the present and previous solutions regardless of the type of vector. In addition, use a locally relevant vector for mesh refinement (in the init_temporary_vector() call). How Has This Been Tested? All existing tests pass. A new test tgv_restart_bdf1 is added to the MF application in serial and in parallel to verify restart feature. Former-commit-id: def88b4
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem Eight tests were failing in debug mode due to the different behavior of the interpolate function of the solution transfer for different types of vectors. Description of the solution Revert change made in chaos-polymtl#1007 for the init_temporary_vector() function. Former-commit-id: 7518c97
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The restart option was not working in parallel for the matrix-free application. Description of the solution Use locally relevant vectors for the present and previous solutions regardless of the type of vector. In addition, use a locally relevant vector for mesh refinement (in the init_temporary_vector() call). How Has This Been Tested? All existing tests pass. A new test tgv_restart_bdf1 is added to the MF application in serial and in parallel to verify restart feature. Former-commit-id: def88b4
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Eight tests were failing in debug mode due to the different behavior of the interpolate function of the solution transfer for different types of vectors. Description of the solution Revert change made in #1007 for the init_temporary_vector() function. Former-commit-id: 7518c97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
The restart option was not working in parallel for the matrix-free application.
Description of the solution
Use locally relevant vectors for the present and previous solutions regardless of the type of vector. In addition, use a locally relevant vector for mesh refinement (in the
init_temporary_vector()call).How Has This Been Tested?
tgv_restart_bdf1is added to the MF application in serial and in parallel to verify restart feature.