Neumann BC for heat #1000

voferreira · 2024-01-26T13:21:40Z

Description of the problem

Lethe did not have a constant heat flux (Neumann) BC

Description of the solution

Implemented a heat flux boundary condition

How Has This Been Tested?

2D jet case
Add application test

Documentation

Added the parameters to the documentation

Future changes

Make it space dependent as well as emissivity, h, and Tinf
Needs some cleaning
Make an example

blaisb

Some mistakes in the weak form and I would name that heat flux instead of heat source

source/solvers/heat_transfer_assemblers.cc

source/core/parameters.cc

include/core/parameters.h

include/core/boundary_conditions.h

source/solvers/heat_transfer_assemblers.cc

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst

oguevremont · 2024-01-26T16:07:34Z

Nice addition!

AmishgaAlphonius

Nice addition! I'm surprised that it wasn't there before! Even more, that I only realized it yesterday when we talked about it. :)

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst

Co-authored-by: Olivier Guévremont <[email protected]>

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst

AmishgaAlphonius · 2024-01-26T18:35:19Z

Also, I just realized, but an application-test can also be added for this new BC. :)

Co-authored-by: Amishga Alphonius <[email protected]>

blaisb · 2024-01-26T21:04:23Z

I think adding an application test would be a good idea. I agree with @AmishgaAlphonius

Co-authored-by: Amishga Alphonius <[email protected]>

voferreira · 2024-01-30T03:22:37Z

As prof @blaisb and I have discussed Today, I will add the imposed heat flux as a term to the Robin BC again because it is more versatile. This will help with the further implementation of the space-dependent Robin BC.

AmishgaAlphonius

One small comment :)

include/core/boundary_conditions.h

blaisb · 2024-01-31T13:03:41Z

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst

@@ -57,13 +61,20 @@ The default parameters for ``temperature`` and ``convection-radiation`` are show
 * ``type``: type of boundary condition being imposed. At the moment, choices are:
    * ``noflux`` (default) so that there is no heat transfer boundary condition,
    * ``temperature`` (Dirichlet BC), to impose a given temperature ``value`` at the boundary,
-    * ``convection-radiation`` (Robin BC) for cooling/heating, depending on the environment temperature at the boundary ``Tinf``, with a given heat transfer coefficient ``h`` and emissivity of the boundary :math:`\mathbf{\epsilon}` following Newton's law of cooling (and heating) and Stefan-Boltzmann law of radiation. Note that the expressions for ``h``, ``Tinf`` and ``emissivity`` can be time-dependent, but the current implementation doesn't allow for space dependence (the expressions are evaluated at the origin).
+    * ``convection-radiation`` (Robin BC) for cooling/heating, depending on the environment temperature at the boundary ``Tinf``, with a given heat transfer coefficient ``h`` and ``emissivity`` of the boundary :math:`\mathbf{\epsilon}` following Newton's law of cooling (and heating) and Stefan-Boltzmann law of radiation. It is also possible to impose a given heat flux (:math:`q_0`) by using the parameter ``heat_flux``. This BC can be represented by:


maybe we would want to rename convection-radiation convection-radiation-flux? If so. I would add a CHANGELOG. But if you want, we can do this in a next PR... This way we can merge this one now

blaisb · 2024-01-31T13:57:19Z

@voferreira write to me on slack when ready for merge :)

Co-authored-by: Amishga Alphonius <[email protected]>

blaisb · 2024-01-31T15:22:00Z

can you please fix CI @voferreira

Description of the problem The convection-radiation-flux boundary condition had function expression parameters that were not space dependent. Description of the solution Made it space-dependent using the function evaluation at the quadrature point position. How Has This Been Tested? Simple 2D heat flux case. The test was added to the application tests. Documentation Remove disclaimer from parameters guide regarding the no longer existent limitation. Comments This PR is a follow up of PR Neumann BC for heat #1000 . There is no way to have set number of fluids = 0. This was added to the maintenance project and I will fix it in another PR. Co-authored-by: voferreira <[email protected]> Co-authored-by: Bruno Blais <[email protected]>

Description of the problem Lethe did not have a constant heat flux (Neumann) BC Description of the solution Implemented a heat flux boundary condition How Has This Been Tested? 2D jet case Add application test Documentation Added the parameters to the documentation Future changes Make it space dependent as well as emissivity, h, and Tinf Needs some cleaning Make an example Co-authored-by: voferreira <[email protected]> Co-authored-by: Olivier Guévremont <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Co-authored-by: Bruno Blais <[email protected]> Former-commit-id: a3a1d26

) Description of the problem The convection-radiation-flux boundary condition had function expression parameters that were not space dependent. Description of the solution Made it space-dependent using the function evaluation at the quadrature point position. How Has This Been Tested? Simple 2D heat flux case. The test was added to the application tests. Documentation Remove disclaimer from parameters guide regarding the no longer existent limitation. Comments This PR is a follow up of PR Neumann BC for heat chaos-polymtl#1000 . There is no way to have set number of fluids = 0. This was added to the maintenance project and I will fix it in another PR. Co-authored-by: voferreira <[email protected]> Co-authored-by: Bruno Blais <[email protected]> Former-commit-id: 51ace0e

Description of the problem Lethe did not have a constant heat flux (Neumann) BC Description of the solution Implemented a heat flux boundary condition How Has This Been Tested? 2D jet case Add application test Documentation Added the parameters to the documentation Future changes Make it space dependent as well as emissivity, h, and Tinf Needs some cleaning Make an example Co-authored-by: voferreira <[email protected]> Co-authored-by: Olivier Guévremont <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Co-authored-by: Bruno Blais <[email protected]> Former-commit-id: a3a1d26

Description of the problem The convection-radiation-flux boundary condition had function expression parameters that were not space dependent. Description of the solution Made it space-dependent using the function evaluation at the quadrature point position. How Has This Been Tested? Simple 2D heat flux case. The test was added to the application tests. Documentation Remove disclaimer from parameters guide regarding the no longer existent limitation. Comments This PR is a follow up of PR Neumann BC for heat #1000 . There is no way to have set number of fluids = 0. This was added to the maintenance project and I will fix it in another PR. Co-authored-by: voferreira <[email protected]> Co-authored-by: Bruno Blais <[email protected]> Former-commit-id: 51ace0e

voferreira added 5 commits January 25, 2024 15:35

Implement the parameter and heat_flux in the rhs

919bd3e

Fix the time update bc

8370b82

Merge remote-tracking branch 'origin/master' into heat_neumann_bc

7947a07

Fix indentation

a43dc2c

Add documentation

a702c46

voferreira requested review from blaisb, oguevremont and AmishgaAlphonius January 26, 2024 13:21

voferreira added Enhancement New feature or request Ready for review labels Jan 26, 2024

Add comment in boundary_conditions.h

d8f7813

blaisb requested changes Jan 26, 2024

View reviewed changes

Fix weak form, rename and remove wrong placed parameter

bd0e2c6

voferreira added WIP When a PR is open but not ready for review and removed Ready for review labels Jan 26, 2024

Indent

bee1323

oguevremont reviewed Jan 26, 2024

View reviewed changes

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst Outdated Show resolved Hide resolved

AmishgaAlphonius reviewed Jan 26, 2024

View reviewed changes

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst Show resolved Hide resolved

voferreira added WIP When a PR is open but not ready for review and removed WIP When a PR is open but not ready for review labels Jan 26, 2024

Apply suggestions by Olivier

d4cf0fb

Co-authored-by: Olivier Guévremont <[email protected]>

AmishgaAlphonius reviewed Jan 26, 2024

View reviewed changes

doc/source/parameters/cfd/boundary_conditions_multiphysics.rst Outdated Show resolved Hide resolved

Apply suggestion by Amishga

7576659

Co-authored-by: Amishga Alphonius <[email protected]>

voferreira added 4 commits January 26, 2024 18:19

Write assembler for Neumann heat flux BC

3701e39

Indent

15fa2e1

Fix bc check in rhs

9d2ced1

Fix sign in rhs

539ba85

voferreira and others added 2 commits January 29, 2024 15:03

Apply suggestions from Amishga

fe48300

Co-authored-by: Amishga Alphonius <[email protected]>

Fix test to match new definition sign of bc

c2337f6

blaisb approved these changes Jan 29, 2024

View reviewed changes

voferreira added WIP When a PR is open but not ready for review and removed Reviewed and waiting for changes labels Jan 29, 2024

oguevremont approved these changes Jan 29, 2024

View reviewed changes

voferreira added 4 commits January 30, 2024 18:48

Update documentation

92f9503

Get BC back to Robin

83f19f7

Fix test

154d1a0

Fix documentation

7b8e2d3

voferreira requested a review from blaisb January 31, 2024 00:18

AmishgaAlphonius approved these changes Jan 31, 2024

View reviewed changes

include/core/boundary_conditions.h Outdated Show resolved Hide resolved

blaisb approved these changes Jan 31, 2024

View reviewed changes

Apply correction by Amishga

bfae696

Co-authored-by: Amishga Alphonius <[email protected]>

voferreira added Reviewed and ready to merge and removed WIP When a PR is open but not ready for review labels Jan 31, 2024

voferreira added 2 commits January 31, 2024 11:43

Indent

004ff6a

Change the type of the bc and add the modification to changelog

c7c98c8

blaisb merged commit a3a1d26 into master Feb 1, 2024
8 checks passed

blaisb deleted the heat_neumann_bc branch February 1, 2024 01:26

voferreira mentioned this pull request May 11, 2024

Robin/Neumann BC parameters were not space dependent #1128

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Neumann BC for heat #1000

Neumann BC for heat #1000

voferreira commented Jan 26, 2024 •

edited

Loading

blaisb left a comment

oguevremont commented Jan 26, 2024

AmishgaAlphonius left a comment

AmishgaAlphonius commented Jan 26, 2024 •

edited

Loading

blaisb commented Jan 26, 2024

voferreira commented Jan 30, 2024

AmishgaAlphonius left a comment

blaisb Jan 31, 2024

blaisb commented Jan 31, 2024

blaisb commented Jan 31, 2024

Neumann BC for heat #1000

Neumann BC for heat #1000

Conversation

voferreira commented Jan 26, 2024 • edited Loading

Description of the problem

Description of the solution

How Has This Been Tested?

Documentation

Future changes

blaisb left a comment

Choose a reason for hiding this comment

oguevremont commented Jan 26, 2024

AmishgaAlphonius left a comment

Choose a reason for hiding this comment

AmishgaAlphonius commented Jan 26, 2024 • edited Loading

blaisb commented Jan 26, 2024

voferreira commented Jan 30, 2024

AmishgaAlphonius left a comment

Choose a reason for hiding this comment

blaisb Jan 31, 2024

Choose a reason for hiding this comment

blaisb commented Jan 31, 2024

blaisb commented Jan 31, 2024

voferreira commented Jan 26, 2024 •

edited

Loading

AmishgaAlphonius commented Jan 26, 2024 •

edited

Loading